Skip to content

[#18] Implement secp256k1 and P256 crypto to full extent

Moremi Vannak requested to merge rinn7e/#18-full-crypto-morley into master

Description

Problem: Currently there are secp256k1 and p256 crypto for working with tz2 tz3 addresses, but they are not implemented fully.

secp256k1 lacks proper decoding and p256 does not have proper implementation all together.

Solution: Implement the missing parts of secp256k1 and p256 so that they can be used to do signature checking properly.

Related issue(s)

Resolves #18 (closed)

Depends on #267 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Moremi Vannak

Merge request reports