Skip to content

[#289] Refactor Morley.Nettest errors types

Diogo Castro requested to merge diogo/#289-refactor-error-types into master

Description

Problem: At the moment, expectFailure accepts UnexpectedBalance and UnexpectedClientSuccess as args, even though it doesn't make sense to say:

expectBalance n `expectFailure` NettestUnexpectedBalance x

Solution: Split NettestFailure into two types: one for errors thrown by the interpreter/client (that the user can expect to happen and handle), and another for errors thrown by cleveland when an assertion fails (which should not be caught, only displayed in the console).

Related issue(s)

Resolves #289 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Merge request reports