Skip to content

[#7] Rename `PairStruct` to `UnpairStruct` and use different `PairStruct` for PAPAIR

Moremi Vannak requested to merge rinn7e/#7-different-pairstruct-papair into master

Description

Problem: PAPAIR and UNPAIR use the same structure (called PairStruct), but current structure is correct only for UNPAIR, because UNPAIR can produce multiple items on stack and hence can have multiple variable annotations, while PAPAIR can't.

So VarAnns inside PairStruct inside PAPAIR are always ignored.

Solution: Rename current PairStruct to UnpairStruct and use different PairStruct which exactly captures set of all possible PAPAIRs.

Related issue(s)

Resolves #7 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Moremi Vannak

Merge request reports