Skip to content

[#106] Retain type annotations in `EpdNone` derivation

Ivan Gromakovskii requested to merge gromak/#106-epd-none-type-anns into master

Description

Problem: currently annotations for parameter type come solely from parameterEntryPointsToNotes call which uses Lorentz.EntryPoints machinery. It is supposed to propagate type annotations generated by TypeAnns.hs module. However, in case of EpdNone we always return starNotes which has no type annotations. We should retain type annotations there.

Solution: change epdNotes definition for EpdNone case. It lead to cyclic dependencies because EntryPoints.Core has to depend on TypeAnns and EntryPoints.Core is used by many modules. In ordero to make it work I removed all Lorentz dependencies from TypeAnns, now we can even move it to morley (into Typed stuff).

Related issue(s)

Resolves #106 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated the changelog if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Ivan Gromakovskii

Merge request reports