Skip to content

[#83] Add more checks to generic multisig

Roman Melnikov requested to merge rvem/#83-update-generic-multisig into master

Description

Problem: There are some additional checks we want to add to the generic multisig contract:

  • Prohibit setting threshold to zero.
  • Prohibit setting threshold which is larger than keys set size.

Solution: Add corresponding checks to the contract code.

Related issue(s)

Resolves #83 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated the changelog if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Roman Melnikov

Merge request reports