Skip to content

[#558] Add Range type to Lorentz

Nikolay Yakimov requested to merge lierdakil/#558-lorentz-range-type into master

I still intend to add some tests.

Description

What it says on the tin.

Additional effort was spent on this condition from the issue description:

error messages on type mismatch remain neat, they should not be like Cannot match 'Natural' with 'RangeInternal 'RangeInclusive 'RangeExclusive'

Ultimately, hiding "ugly internals" with things like TypeErrors can work in some cases, but generally it hurts type inference due to use of incoherence. Thus, "ugly internals" are hidden behind newtypes instead.

Related issue(s)

Resolves #558 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Nikolay Yakimov

Merge request reports