[#941] Split Resolve (AddressOrAlias kind) into two
Description
Problem: Resolve (AddressOrAlias kind)
instance does too much, from the
convenience and separation of concerns point of view it makes sense to
have Resolve (KidnedAddress kind)
and Resolve (Alias kind)
, and let
Resolve (AddressOrAlias kind)
delegate to those two.
Solution: Do that. Also remove now-redundant uses of AddressResolved
and AddressAlias
wrappers and WithClientLog
constraints.
Also, slightly generalize AmbiguousAlias
error and move it to ResolveError
(semantically it is). Also, don't throw from resolve*Either
.
Related issue(s)
Resolves #941 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.
Edited by Nikolay Yakimov