Skip to content

[#761] Proper dangerbot merge commit checks

Description

Problem: Current implementation of merge commit checks only checks the commit subject, which may in fact be arbitrary.

Solution: Check commit's parents count instead. Merge commits have more than one parent by definition.

Related issue(s)

Resolves #761 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Nikolay Yakimov

Merge request reports

Loading