[#918] Simplify ReferencedByName
Context: I was looking at our uses of unsafeProvideConstraint
(which are very few, btw, so arguably we might want to get rid of those entirely), and noticed this and got distracted fixing it.
Context 2: I've realized the old code could crash at runtime, so I filed #918 (closed) which this happens to fix.
Description
Problem: we use unsafeProvideConstraint
to assert the consequent, but we
don't actually need it, GHC is smart enough to derive everything on its
own provided it has enough context.
Solution: carry enough context in VarPosition
.
This also adds a few doctests.
Related issue(s)
Resolves #918 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.
Edited by Nikolay Yakimov