[#889] Overload `getAlias`
Description
Problem: In !1260 (merged), we added the type SomeAddressOrAlias
and overloaded resolveAddress
to work with both SomeAdressOrAlias
and AddressOrAlias kind
.
However, getAlias
still only works with AddressOrAlias
.
Solution:
- Rename the
ResolveAddress
typeclass to simplyResolve
- Add a
getAliasEither
method to theResolve
typeclass - Implement
getAlias
andgetAliasMaybe
in terms ofgetAliasEither
- Replace
HasTezosClient.findAlias
method with the more generalHasTezosClient.getAliasesAndAddresses
. This can be used to implement bothresovleAddress
andgetAlias
.
Related issue(s)
Resolves #889 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.
Edited by Diogo Castro