Skip to content

[#895] Add getAliasMaybe to morley-client

Markus Barenhoff requested to merge alios/#895-alias-maybe into master

Description

Just like we have resolveAddressMaybe and resolveAddress, we should also have getAliasMaybe and getAlias.

  • HasTezosClient now exposes as getAliasEither which returns a Left KindedAddress kind if the alias could not be resolved
  • getAlias has moved from the HasTezosClient class to Morley.Client.TezosClient.Impl module
  • getAliasMaybe has been added (in MorleyClient.TezosClient.Class)
  • morley-client tests now throw and UnknownAddress exception (like the "real" getAlias) instead UnknownContract

Related issue(s)

Resolves #895 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Markus Barenhoff

Merge request reports