Skip to content

[#849] Fix secp256k1 signatures

Nikolay Yakimov requested to merge lierdakil/#849-fix-secp-signatures into master

Description

Problem: roughly half of all our secp256k1 signatures are rejected by the network.

Solution: mimic bitcoin-core implementation of the signature (used internally by tezos): avoid signature s parameter exceeding half group order.

Related issue(s)

Resolves #849 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Merge request reports