Skip to content

[#824] General cleanup

Diogo Castro requested to merge diogo/#824-cleanup into master

Description

While working on #824 (closed), I happened to come across a few unrelated things that needed to be cleaned up and a bug:

  • We should enable the InstanceSigs extension globally
  • In the Pure module, we were using Text where we should have been using the Alias data type.
  • We had no tests for cleveland's resolveAddress
  • Bug: In Pure, when a contract fails, we were enriching the ExecutorError with the contract's alias - however, the exceptionHandler was discarding this data, so the contract's alias never showed up in error messages as intended.

This MR fixes all of the above.

Related issue(s)

Resolves part of #824 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Diogo Castro

Merge request reports