Skip to content

[#836] Typechecker fixes

Nikolay Yakimov requested to merge lierdakil/#836-typecheck-fixes into master

Description

  • Remove unused TypeCheckPack mode

  • Do not throw error in the typechecker

  • Set typecheck mode in typeCheckValue

    Apparently, SELF inside a pushed lambda unit unit was considered well-typed by morley 😕 Well, not any more.

  • Hotfix: give IsNotInView in test typecheck

    Follow-up to #829 (closed), morley repl complains about views when typechecking SELF, TRANSFER_TOKENS, etc, which is confusing and wrong.

  • Add a contract testing self in lambda

    Apparently we didn't test for it? Well, here's a test.

Related issue(s)

Resolves #836 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Merge request reports