Draft: [#729] Handle contract aliases properly
Description
Problem: Smart contract and implicit account alias namespaces intersect in a few places, and those places need special care.
Solution: In morley-client:
-
resolveAddress
andresolveAddressMaybe
only look up implicit accounts. We don't really look up contracts by alias AFAIK - aliases in
revealKey
andcalcRevealFee
are now prefixed withkey:
to disambiguate from contracts (this is tezos-client syntax) -
getAlias
looks up either contracts or implicit accounts depending on the key type.
In Cleveland.Internal.Pure:
- Keep contract and key aliases in separate maps to avoid mixing them up
Related issue(s)
Resolves #729 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.
Edited by Nikolay Yakimov