Skip to content

[#264] Make `dfsTraverseValue` parameterized by `DfsSettings`

Moremi Vannak requested to merge rinn7e/#264-ctoreffect into master

Description

Problem: Unlike dfsTraverseInstr, dfsTraverseValue doesn't provide any way to specify how effects should be applied (see DfsSettings).

And because of that when it encounters a value with instructions it doesn't respect DfsSettings to full extent (e. g. if there is a pair of two lambdas).

Solution: Make dfsTraverseValue parameterized by DfsSettings.

Related issue(s)

Resolves #264 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Moremi Vannak

Merge request reports