Skip to content

[BTG-32] Fix git revision inclusion

Konstantin Ivanov requested to merge martoon/btg32-fix-git-rev into master

Description

Problem: in 'DGitRevision' documentation item I called template haskell which fetches commit sha and date internally rather than at call site, and this is obviously incorrect as can observed in depending projects.

Solution: make 'mkDGitRevision' function return TH expression which yet should be instantiated.

Related issue(s)

https://issues.serokell.io/issue/BTG-32

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:

Stylistic guide (mandatory)

Edited by Konstantin Ivanov

Merge request reports