Skip to content
Snippets Groups Projects

[#771] Clarify morley commands difference

Merged Dmitry requested to merge krendelhoff/#771-commands-difference-clarification into master

Description

Problem: It's unclear that run, transfer and originate morley commands work on emulated environment.

Solution: That commands were put under "emulate" parent command.

Related issue(s)

Resolves #771 (closed)

:white_check_mark: Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Dmitry

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pinto Pasquale
  • Pinto Pasquale
  • Pinto Pasquale mentioned in merge request !1096 (merged)

    mentioned in merge request !1096 (merged)

  • Dmitry changed the description

    changed the description

  • Dmitry resolved all threads

    resolved all threads

  • Dmitry added 11 commits

    added 11 commits

    Compare with previous version

  • Dmitry marked the checklist item Haddock as completed

    marked the checklist item Haddock as completed

  • Dmitry marked the checklist item I updated changelog files of all affected packages released to Hackage if my changes are externally visible. as completed

    marked the checklist item I updated changelog files of all affected packages released to Hackage if my changes are externally visible. as completed

  • Pinto Pasquale
  • Pinto Pasquale resolved all threads

    resolved all threads

  • @krendelhoff as I mentioned elsewhere there's no need to have so much granularity in commits, except during review, but fixup commits work better for that.

    E.g. in commits like 8f298b710bc010bbf6df1b94508b8f32914f9b18 there's more data in the message then in the change made :slight_smile:

    Merging these would make the commit history much more messy, which isn't great, so please rebase this MR and squash all the current commits in a single one.

  • Pinto Pasquale resolved all threads

    resolved all threads

  • Dmitry added 4 commits

    added 4 commits

    Compare with previous version

  • Dmitry marked the checklist item Root README and other README.md files as completed

    marked the checklist item Root README and other README.md files as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading