[#753] Fix/drop/comment noncanonical Show instances
Description
Problem: there are many Show
instances in morley
that do not produce valid Haskell representations of show
n terms. In particular, missing outward parens and use of Show
for pretty-printing are common.
Solution: move pretty-printing into Buildable
instances; make Show
instances stock
derived where possible; drop unnecessary Show
s; reimplement necessary Show
s where stock instances are impossible or unsatisfactory; comment noncanonical Show
s deemed not worth the trouble with motivation for their existence and noncanonicity.
Related issue(s)
Resolves #753 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.
Edited by —