[#725] Modify resolveAddress to accept AliasHints
I'm a bit conflicted about two points:
-
Do we actually need to
resolveAddress
for raw aliases? One scenario I can imagine is resolving an address that was set up in tezos-client by environment somehow. Do we want to support this use case, however? It's obviously unsupported on the emulator without some horrible hacks.The answer we arrived at is "no"
-
If we do want to support
resolveAddress
for raw aliases, would it make more sense to have a separate function for that instead of using awkward overloads?We don't
Description
Problem: Most of our interface accepts AliasHints, but resolveAddress accepts a raw Alias. This, together with implementation detail of PureM, leads to inconsistencies in behaviour.
Solution: Make resolveAddress accept AliasHint. In case someone ever needs to resolve raw aliases, they can use morley-client API directly.
Related issue(s)
Resolves #725 (closed)
✅ Checklist for your Merge Request
Related changes (conditional)
-
Tests (see short guidelines)
-
If I added new functionality, I added tests covering it. -
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
-
-
Documentation
Stylistic guide (mandatory)
-
My commits comply with the following policy. -
My code complies with the style guide.