Skip to content
Snippets Groups Projects

[#723] Add synonyms for SomeConstrainedValue

Merged [#723] Add synonyms for SomeConstrainedValue
1 unresolved thread
Merged Nikolay Yakimov requested to merge lierdakil/#723-some-constrained-value-synonyms into master
1 unresolved thread

This is more of an RFC.

There is some simplification, specifically, we don't have to define instances for each new existential (at least if we're willing to use quantified constraints), and adding synonyms is nearly trivial.

That said, not like this affects the code base in any meaningful way, unless we choose to remove synonyms and use SomeConstrainedValue everywhere, which IMO is less readable overall.

Description

Problem: We're defining SomeValue, SomeStorage and SomeConstant as separate existential wrappers, while we have SomeConstrainedValue already.

Solution: Define SomeValue, SomeStorage and SomeConstant in terms of SomeConstrainedValue. Define instances on SomeConstrainedValue directly.

Related issue(s)

Resolves #723 (closed)

:white_check_mark: Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Nikolay Yakimov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pinto Pasquale
  • Pinto Pasquale
  • added 1 commit

    Compare with previous version

  • Pinto Pasquale resolved all threads

    resolved all threads

  • Pinto Pasquale approved this merge request

    approved this merge request

  • Dmitriy Mozhevitin approved this merge request

    approved this merge request

  • Nikolay Yakimov added 11 commits

    added 11 commits

    Compare with previous version

  • Nikolay Yakimov approved this merge request

    approved this merge request

  • Nikolay Yakimov marked this merge request as ready

    marked this merge request as ready

  • Nikolay Yakimov enabled an automatic merge when the pipeline for 181f5d33 succeeds

    enabled an automatic merge when the pipeline for 181f5d33 succeeds

  • Nikolay Yakimov mentioned in commit 2c67052d

    mentioned in commit 2c67052d

  • Please register or sign in to reply
    Loading