Skip to content

[Chore] make newline and trailing whitespaces suggestions more clear

Pinto Pasquale requested to merge pasqu4le/chore-clear-danger-suggestions into master

Description

Problem: danger suggestions for trailing whitespaces and end-of-file newlines aren't very clear because they are rendered similarly and the output error message only mentions the former. This makes it a bit hard to understand that only a newline is missing for example.

Solution: improve danger's output failure message as well as the comments that it leaves with suggestions.

Related issue(s)

None

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Pinto Pasquale

Merge request reports