SSWG Review Feedback
During the feedback thread for reviewing the SSWG-0004 RedisNIO proposal, several action items were identified to make RedisNIO the best it can be for 1.0.0.
-
Change RedisCommandHandler
fromopen
topublic final
-
Move & Rename Redis.makeConnection
toRedisConnection.connect
-
Move & Rename Redis.makeDefaultClientBootstrap
toClientBootstrap.makeRedisTCPClient
-
Remove Redis
namespace enum -
Add label to RESPValueConvertible.init
requirement -
Change RESPTranslator
logic to copy theByteBuffer
and move the reader index instead of a mutable position value. -
Clarify language in RESPClient.expire
to be consistent with timeouts instead of deadlines -
Rename RedisCommandContext
toRedisCommand
- This should include documentation to warn users of reference semantics from the
EventLoopPromise
- This should include documentation to warn users of reference semantics from the
Edited by Nathan Harris