SSWG Review Feedback
During the feedback thread for reviewing the SSWG-0004 RedisNIO proposal, several action items were identified to make RedisNIO the best it can be for 1.0.0.
-
Change RedisCommandHandlerfromopentopublic final -
Move & Rename Redis.makeConnectiontoRedisConnection.connect -
Move & Rename Redis.makeDefaultClientBootstraptoClientBootstrap.makeRedisTCPClient -
Remove Redisnamespace enum -
Add label to RESPValueConvertible.initrequirement -
Change RESPTranslatorlogic to copy theByteBufferand move the reader index instead of a mutable position value. -
Clarify language in RESPClient.expireto be consistent with timeouts instead of deadlines -
Rename RedisCommandContexttoRedisCommand- This should include documentation to warn users of reference semantics from the
EventLoopPromise
- This should include documentation to warn users of reference semantics from the
Edited by Nathan Harris