Skip to content

Improve loading state #3

Ben requested to merge fix/loading-state-3 into master

Ticket(s) / Related Merge Requests

#3 (closed)

Summary of Changes

Improve loading state by

  • Temporarily removing ... from loading state - we can come back and revisit a more visually appealing loading state in the future.
  • Fixing color-scheme to be normal - meaning that if implementing sites are using color-scheme, it will be ignored in the iframe.

Testing Considerations

  • I see no loading ... when loading the embed app.
  • I see no white flash while loading the embed app.

Test the below from your local (if the sandbox becomes unavailable please message me) - note bg is changed to green to make it clear whether a white bg shows during loading:

<html>
  <head>
    <title>Embedded boosts test app</title>
  </head>

  <body>
    <h1>Embedded boosts test app</h1>
    <p>Below you will see an embedded Boosts from my network.</p>

    <div
      class="minds-boost-slot"
      data-height="600px"
      data-width="300px"
      data-theme="fishtank"
      data-border-color="rgba(80, 80, 80, 1)"
      data-app-url="https://ben3.oke.minds.io/plugins/embedded-boosts/"
    ></div>

    <script
      async
      defer
      crossorigin="anonymous"
      src="https://ben3.oke.minds.io/plugins/embedded-boosts/js/embed.min.js"
    ></script>
  </body>
</html>

<style>
  :root {
    color-scheme: dark;
  }

  body {
    background-color: green;
  }
</style>

Deployment Considerations

Standard deployment - make sure to restart embedded comments app.

Regression Scope

Embedded comments app loading state.

Platform Affected (web, mobile, etc)

Embedded comments app.

Developer Testing Completed

Units passing.

Screenshots / Screen Recording

simplescreenrecorder-2024-06-24_19.30.07

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports