Ticket(s) / Related Merge Requests
Summary of Changes
-
removed pushInteractionsBottomSheet and replaced with pushInteractionsScreen: Bottom sheets are not supposed to stay on the screen after navigation by design and we have a lot of strange functionalities happening because of this.
-
Fixed an issue with back button on android
-
Fixed some issues of screens opening in AppStack instead of their respective tabs
-
Changelog file updated with this template (one or more) -
Added for new features. -
Changed for changes in existing functionality. -
Deprecated for soon-to-be removed features. -
Removed for now removed features. -
Fixed for any bug fixes. -
Security in case of vulnerabilities.
-
Testing Considerations
- make sure you test all these instances of interaction bottom sheet:
- open post from newsfeed, open upvotes/downvotes/reminds/quotes ("interactions")
- do the same with a post from discovery, notifications, and channel from drawer (testing only one is enough)
- if you can remember another place these interactions are opened, test that as well (I think its just the above)
- make sure posts and channels open in the notifications screen instead of opening over the tabs
- make sure #5142 (closed) is fixed
Regression Scope
- All bottom sheets back functionality (tapping on the 'x' and android back button and swipe-down gesture. Also check the interactivity of the screen behind the bottom sheet after you do all this)
- all interaction bottom sheets
Platform Affected (web, mobile, etc)
ios and android
Developer Testing Completed
and, ios
Screenshots
Does this impact
-
Localization -
Dark/light mode -
Guest mode