Skip to content

Refactor media picker with expo-image-picker #4410

Martin Santangelo requested to merge native/image-picker-refactor into develop

Ticket(s) / Related Merge Requests

#4410 (closed)

Summary of Changes

Replaced the react-native-crop-picker with expo-image-picker and cleaned up a little bit the code

All the picker packages (and others) still suffer from restart errors on android. Apparently related to (https://github.com/facebook/react-native/issues/30277)

  • Changelog file updated with this template (one or more)
    • Added for new features.
    • Changed for changes in existing functionality.
    • Deprecated for soon-to-be removed features.
    • Removed for now removed features.
    • Fixed for any bug fixes.
    • Security in case of vulnerabilities.

Testing Considerations

The following functionality was affected and should be tested:

  • Channel editor avatar and the banner picker (Including the crop functionality) Keep in mind that the crop for the banner is only enabled on android
  • Image picker from the composer
  • Image/video picker and camera capture from comments

Regression Scope

Should affect media picking only

Platform Affected (web, mobile, etc)

Both

Developer Testing Completed

iPhone XR, Xiaomi Note 10 lite

Screenshots

Simulator_Screen_Shot_-iPhone_14-_2023-01-30_at_14.37.55

Simulator_Screen_Shot_-iPhone_14-_2023-01-30_at_14.38.03

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Martin Santangelo

Merge request reports