Skip to content

Fix random zoomed images on android and cutoff perma link thumbnails #4453

Martin Santangelo requested to merge fix/image-zoom-android into develop

Ticket(s) / Related Merge Requests

#4453 (closed)

Summary of Changes

The issue is caused by a react-native-fast-image package that is scaling the images even when there is no need to (The aspect ratio of the image matches the container)

I solved it by changing the default resize mode to contain instead of cover

I also used contain for the fixed height images (Embedded link images for instance), this will solve the cutoff images for links. The only drawback is that we are going to have some darker borders

Testing Considerations

Check issue

Regression Scope

It only affects the posts' images

Platform Affected (web, mobile, etc)

Both but the image zoom was happening only on Android

Developer Testing Completed

Android device and iOS sim

Screenshots

Screen_Shot_2022-08-29_at_15.00.03

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Merge request reports