Skip to content

Fix highlights should have only 3 items #4447

Martin Santangelo requested to merge fix/highlight-3-items into develop

Ticket(s) / Related Merge Requests

#4447 (closed)

Summary of Changes

Removed pagination to the data store and moved the loading logic outside the component.

Removed the clean-up of limit and params of the feed service inside the clear method. This was causing issue when a FeedStore was reset, the "configuration: was lost so the next fetch will be called with the default limit & params

Testing Considerations

  • open the app
  • refresh the newsfeed many times or switch users
  • it should never show more than 3 highlights

Regression Scope

it should affect highlights only

Platform Affected (web, mobile, etc)

both

Developer Testing Completed

ios simulator

Screenshots

demo

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Martin Santangelo

Merge request reports