Skip to content

Fix Reset password issues #4341 #4342 #4339

Manish requested to merge fix/reset-pass-issues-4341 into develop

Ticket(s) / Related Merge Requests

Closes #4341 (closed), #4342 (closed), and #4339 (closed)

Summary of Changes

Closes #4341 (closed) and #4342 (closed) by fixing the ResetPassword functionality. The fix includes turning that modal from a BottomSheetModal implementation to a Screen with ModalContainer. This MR also changes the Password Reset's initialization logic in AppInitManager.

Testing Considerations

  • forget password functionality in Login screen
  • Functionality of reset password and "Create a new password" (different states of the same component). Especially the success functionality (navigation and session management after reset password is finished)
  • styling of the reset psw modal
  • Functionality after clicking the reset password link in Mail
    • when app is closed (cold start)
    • when app is running in the background
      • on the newsfeed
      • when the user has navigated deep in some part of the app. e.g. Settings->Account->Password
  • Does 2FA Modal play nicely with the Reset Password modal?
  • Password reset when you already have that user logged in
  • Password reset when you don't have that user logged in

Regression Scope

  • App initialization
  • Reset Password Modal

Platform Affected (web, mobile, etc)

All

Developer Testing Completed

local iOS and Android

Screenshots

Screen_Shot_2022-06-28_at_17.22.07

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Manish

Merge request reports