You need to sign in or sign up before continuing.
Fix ImageViewer image dimensions #4031
Ticket(s) / Related Merge Requests
(Any issue cards for the merge request, and related merge requests/dependencies)
Summary of Changes
(Summarize the changes made concisely)
Some entities don't have custom_data and in ImageViewer we were relying on it to handle the dynamic height. This MR adds support for entity.height and entity.width as well as custom_data properties
Testing Considerations
double tap on a tall image in the notifications feed and the image should be shown correctly
Regression Scope
(Can this change cause another regression issue? Which areas to focus on for regression testing?)
Image viewer: double tap on many images and check whether they're fine
Platform Affected (web, mobile, etc)
(Which platforms are affected by this change? Web, Mobile, or Both?)
all
Developer Testing Completed
(What has been tested already?)
local- ios
Screenshots
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Edited by Manish