Skip to content

Fix push navigation restarting app and notification opened twice #4332 #4337

Martin Santangelo requested to merge fix/push-navigation-restart into develop

Ticket(s) / Related Merge Requests

Both fixes are in the package:

App restart https://github.com/Minds/react-native-notifications/pull/9 #4332 (closed)

Notification opened twice https://github.com/Minds/react-native-notifications/pull/10 #4337 (closed)

Summary of Changes

  1. The push notification package was restarting the activity when the user taps on a push notification with the app running in the background.

  2. The push notification onOpened event was fired twice the second time a notification was opened by the user (with the app in the background)

I fixed this issue on our fork and if it works correctly in our test I will open an MR against the original repo (Wix)

Testing Considerations

  1. #4332 (closed) Use an Android 12 device
  • Tap on a push notification with the app running in the background
  • It should navigate to the correct screen
  1. #4337 (closed) Use an Android 12 device
  • Leave the app in the background
  • Tap on the first notification (it navigates correctly)
  • move the app to the background again
  • Tap on the second notification
  • It navigates to both notifications

Regression Scope

It only affects android push notifications

Platform Affected (web, mobile, etc)

Android

Developer Testing Completed

I tested on real devices Android 12 & 10

Screenshots

Screenrecorder-2022-06-21-10-03-19-329_0_COMPRESSED

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Martin Santangelo

Merge request reports