Fix 2FA resend functionality #4226
Ticket(s) / Related Merge Requests
closes #4226 (closed)
Summary of Changes
Fixes the 2FA resend functionality and its feedback (toast). Previously the resend button worked but only once, and it didn't have any feedback (notification toast)
Testing Considerations
- 2fa using app code, SMS, and Email should be tested
- try changing email from setting for example to prompt the 2fa modal (other places should also be tested such as password change)
- on the 2FA modal, press the resend button and it should show a toast saying "Email sent"
- on the TOTP (app-based 2FA) 2fa modal, the link should say "Recovery code" and when pressed it should say "Authentication code"
- Resend functionality now has a 10s rate limit
- 2fa on login and on multi-user support should also be tested
Note: I'm not sure if we support SMS 2fa. But if we do, it shouldn't be affected
Regression Scope
- 2fa functionality
- resend functionality
- 2fa screen ui
Platform Affected (web, mobile, etc)
all
Developer Testing Completed
manual, local
Screenshots
(Any extra UI screens that can be shared)
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Edited by Manish