Skip to content

Fix notifications loading inconsistency

Martin Santangelo requested to merge fix/notification-loading-inconsistency into release/4.23.1

Ticket(s) / Related Merge Requests

#4256 (closed)

Summary of Changes

This MR fixes the state management in the notification screen, the loading logic was broken by the dependencies of the useCallback hooks. Causing inconsistencies between tab changes (The content of the tab was replaced with the content of the previous one.

I also fixed the refresh logic that was broken, it was not sending the parameters to the refresh method

Testing Considerations

  • Open the notifications screen

  • Change tabs

  • The notifications of the tab should be loaded correctly (should not be replaced by other tab's notifications)

  • Open the notifications screen

  • change the tab

  • Return to the notifications screen

  • It should automatically refresh

Regression Scope

None

Platform Affected (web, mobile, etc)

Both

Screenshots

4256

Merge request reports