Skip to content

Standardize the keyboard handling #4097

Martin Santangelo requested to merge feat/keyboard-handling into release/4.22.0

Summary

This MR:

  • Changes the soft input mode of android to asjustResize
  • Removes the SoftInput manager package for android
  • Updated the Keyboard aware scroll view package
  • Removes the usage of the KeyboardAvoidingView (replaced by the KeyborarAwareScroll view in most cases)
  • Disables by default the KeyboardSpacingView on Android (enabled=IS_IOS)
  • Adds a KeyboardShift component with functionality similar to the KeyboardAvoidingView (with padding behavior) for android

While working and testing on both platforms I found that the KeyboardAvodingView was not working in some cases on iOS and that the KeyboardShift component has issues on Android when the child is a ScrollView and the input are close to the bottom of the screen. Because of that for now we are using the KeyboardSpacingView and the KeyboardAwareScrollView that give the same or similar experience to the user.

Despite the KeyboardShift component is not used at the moment I left the component because it can be useful in the future

closes #4097 (closed)

Steps to test

Test all the screens where the keyboard is shown and check that the keyboard doesn't cover the input.

  • Composer
  • Comments input
  • Search screen
  • Tags manager (Add button)
  • Settings screens (Password, email, etc)

Estimated Regression Scope

This MR can affect all the screens where the keyboard is shown

Edited by Martin Santangelo

Merge request reports