Skip to content

Fix bottom tabs icon size; quick performance review

Rafael Caferati requested to merge fix/4.19.0/reviewed-icon-map into release/4.19.0

Closes #3669 (closed) and #3666 (closed)

Icon sizes/animation review

This is just a quick fix for the 4.19.0 release. The medium icons on the bottom seem odd, mainly because the multiplier is still not active. Changing it to the large one looks generally better. Also increased the mass on the scale up animation, it was way too bouncy.

  • Changed bottom tab icons to large
  • Increased scale animation mass

Performance review

As an extension for mitigating the scroll low performance on android

  • useStyles were removed from MText and the Icon components as it was throwing their rendering time up on the profiler's rank and not affecting the styling performance itself as every style is send as an ID from StyleSheet.create.
  • Refactored the PressableScale animation for using RN's own Animated API in order to avoid the reanimated scroll error that's mostly causing the Android app to slow down scroll and crash. (RN 0.65.1 vs RR 2.2.2 issue)
  • As we're touching the performance layer, I've added the detachInactiveScreens to the tab navigator which avoid the re-rendering of the main tabs (that was causing a bit of a slowness on tab change for older androids). It shouldn't have any extra impacts but we can observe if it is gonna create any memory issues on these same old devices for having all three views in memory at the same time.
Edited by Rafael Caferati

Merge request reports