Skip to content

Fixed failing hashtag visibility toggle. #2372

Ben requested to merge fix/visibility-toggle-sidebar-2372 into master

Summary

Closes #2372 (closed),

Fixed failing hashtag visibility toggle.

image

Currently on production, if you click a hashtag, and check the URL, it updates fine with the hashtag, but if you click it again to turn it off, it does not.

Steps to test

  1. Go to discovery feed.
  2. Toggle on a hashtag of your choosing.
  3. Check the URL updates accordingly
  4. Click again
  5. The 'hashtag' segment should be gone from the URL

Also, you should be able to toggle directly between hashtags.

Estimated Regression Scope

This effects a small segment of the sidebar selector (specifically one function that's called on click event hashtagVisibilityChange). This should only be able to affect the updating of URLs when that button is clicked. Regardless, in the worst-case calamity situation, maybe the event propagation could break the sidebar feed, or stop the URL updating properly when using the selector.

image

Merge request reports