Fix membership modal showing with no memberships minds#4832

Ticket(s) / Related Merge Requests

minds#4832 (closed)

Summary of Changes

Fix site membership modal showing when no memberships are present.

Testing Considerations

Bound to https://ben2.oke.minds.io/

• Test when there are memberships the modal shows after onboarding.
• Test when there are NO memberships the modal DOES NOT show after onboarding.
• Test the membership page behaves correctly when there are memberships.

Deployment Considerations

Standard deployment.

Regression Scope

Membership modal for tenants.

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

Manual, unit (jasmine / karma).

Screenshots / Screen Recording

when there are memberships the modal shows after onboarding.

simplescreenrecorder-2024-04-26_19.11.50

when there are NO memberships the modal DOES NOT show after onboarding.

simplescreenrecorder-2024-04-26_19.08.24

membership page behaves correctly when there are memberships.

Does this impact

• Localization
• Dark/light mode
• Guest mode

Definition of Done Checklist

• The Acceptance Criteria has been met
• Code is tested: Testing includes unit/spec, E2E/automated and manual testing
• Merge requests description has been filled out