Skip to content

Login onboarding buttons pushed offscreen in safari minds#4572

Olivia Madrid requested to merge fix/login-onboarding-btn-safari-m4572 into master

Ticket(s) / Related Merge Requests

minds#4572 (closed)

Summary of Changes

Adjust styles for fullscreen auth (e.g. login/register/oidc username creation) and onboarding modals so the buttons are reliably onscreen.

Testing Considerations

Auth modals, onboarding modals.

Deployment Considerations

Regression Scope

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

Long forms, short forms, onboarding forms, auth forms, tall screens, short screens, wide screens, narrow screens, chrome on web, safari on web, chrome on iOS, safari on iOS, See screenshots. Tested on iOS simulator to ensure previous fix for the same problem on iOS was not broken.

Screenshots / Screen Recording

image

image

image

image

image

Note theres a weird gap that appears on safari in iOS when the url input bar loses focus. Has to do with how height is calculated. I presume it is already behaving like this.

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out

Merge request reports