Tenant bulk invites minds#4555

Ticket(s) / Related Merge Requests

minds#4555 (closed)

Summary of Changes

👀 Notes

It seems the results of the this.myQuery.valueChanges subscription returns ONLY the newly-fetched items. In contrast, in similar existing queries (e.g. the roles>users list) entire list of results are returned (so we need to slice off the length of the old results before adding them to the list$). This way seems more efficient but it is worth noting that its behavior is different from the other graphql lists I've worked with. Maybe @fausto.arci knows something more about this?

Testing Considerations

⛔️ Known issues

Cancel invite function is not working. I've tried with two users with admin access. Php logs say:

Update: resolved

 An error occurred while evaluating expression in @Security annotation of method "Minds\Core\Email\Invites\Controllers\InvitesController::cancelInvite": Variable "loggedInUser" is not valid around position 26 for expression `is_granted('ROLE_ADMIN', loggedInUser)`.

We might want to address the response structure for the create/resend/cancel functions. For example the resend function is returning {resendInvite: null} - it's not clear whether it was a success or not. @fausto.arci Update: kept as is

Deployment Considerations

Regression Scope

Network console admin > invite tab

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

Everything listed in the summary of changes

Screenshots / Screen Recording

Does this impact

• Localization
• Dark/light mode
• Guest mode

Definition of Done Checklist

• The Acceptance Criteria has been met
• Code is tested: Testing includes unit/spec, E2E/automated and manual testing
• Merge requests description has been filled out