Skip to content

Fix full width page hamburger menus minds#4371

Ben requested to merge fix/full-width-hamb-m4371 into master

Ticket(s) / Related Merge Requests

minds#4371 (closed)

Summary of Changes

Fixes an issue with full-width page hamburger menus where they do not open. Seems to have been a regression from the introduction of the sidebar v2, where a display: block was not being properly set, as it was being overridden by a display: hidden !important.

Testing Considerations

Test various full-width (e.g. /canary, /about/upgrades) and non-full-width pages on mobile.

Deployment Considerations

Standard deployment.

Regression Scope

Sidebar nav display on full-width pages (should only display when menu is clicked on mobile, given a full-width page has no wide-bar when full-width).

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

CSS change - manual.

Screenshots / Screen Recording

simplescreenrecorder-2023-12-14_13.08.52

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports