1x remind minds#4340

Ticket(s) / Related Merge Requests

minds#4340 (closed)

Summary of Changes

• when a user clicks the remind dropdown button, check whether they've reminded it before
• Display "remind" if they haven't reminded already, and "undo remind" if they have
• During the moment when we're performing the check, clicking the "remind" option won't do anything (menu will remain open)
• If making a new remind is in progress, clicking the "remind" option won't do anything
• If undoing a remind is in progress, clicking the "remind" option won't do anything
• changed dropdown menu to ignore clicks on disabled items
• centralized logic for deleting a post by moving it all to the activity.service instead of having it trickle into the parent activity.component via children
• moved "undo remind" logic to the activity.service so it can be used by both the remind button and also the "undo remind" option in the dropdown menu of a reminded post
• unrelated but was bothering me: removed view count from the composer quote post preview

Testing Considerations

Reminds - creating them, undoing them

Notes:

• displaying the remind button with a highlighted color is only possible for the user's remind itself, not for the original post (i.e. unless we're looking at the user's remind, the remind button will be grey)
• if you are on a feed and click to "undo remind" when you have multiple existing reminds of that post, the only one that will be removed from the feed without a refresh is the one that you clicked "undo remind" from. The other ones will still be visible. The counts for the remaining ones will not change either.

Deployment Considerations

Regression Scope

Reminds

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

• doesn't break when remind button clicked while logged out
• works on posts in feed
• works on SEPs
• removes only your reminds, not anyone else's
• removes large quantities of reminds
• undoing a remind removes it from the feed
• deleting a post removes it from the feed
• clicking 'undo remind' from the three-dots menu of a remind removes it from the feed
• when user makes a remind from the remind button, the button becomes yellow
• only ask api whether the user has reminded when they first click on the remind button

Screenshots / Screen Recording

__oneRemindAsyncCheck

Does this impact

• Localization
• Dark/light mode
• Guest mode

Definition of Done Checklist

• The Acceptance Criteria has been met
• Code is tested: Testing includes unit/spec, E2E/automated and manual testing
• Merge requests description has been filled out