Topbar alerts minds#3884

Review changes
Download
Patches
Plain diff

Ben requested to merge feat/topbar-alerts-m3884 into master Mar 23, 2023

Overview 0
Commits 5
Pipelines 3
Changes 17

Ticket(s) / Related Merge Requests

minds#3884 (closed)

Summary of Changes

Topbar alert component.

Testing Considerations

Colours have been confirmed by @chints98

On login or registration, you should see the notice. It will re-appear on login as agreed because it is stored in local storage. On dismiss it should vanish and stay vanished until you log back in. Copy has been agreed upon with the design team.

For reasons discussed in the Regression Scope section - we need to be EXTRA careful that the page layout doesn't break around the topbar, including things appearing behind the topbar that should not and the topbar being mispositioned. The ENTIRE PAGE is structured around the height of the topbar, so potentially for example, in the event of regression, there could be a gap between the topbar and composer, or the composer could be tucked under the topbar partially, or maybe the elements in the topbar overlap the border and are misaligned. Of course, I have tested all of this thoroughly but I'm just trying to give you an idea of some of the hard-to-predict side effects this could have to help your testing process.

Notable states to check:

Web / With Notice.
Web / Without Notice.
Mobile Web / With Notice.
Mobile Web / Without Notice.
Verify email notice with and without notice (it is sticky top based on topbar height)

Ontop of that you need to check dismiss behaviour - it should hide until you log in and out (behaviour confirmed in stand-up).

Deployment Considerations

Standard deployment but HAS to be merged AFTER the new design system is in.

Regression Scope

This change comes with a surprisingly complex regression scope. The entire page's vertical layout is very dependent on the fixed topbar height so that we know where to position the feed and sidebars under it (as it is sticky-positioned). This change effectively adds new sidebar heights for mobile and web when the alert is active, and changes some of the values used to size the topbar to start with.