Notification ACL check #1992

Ticket(s) / Related Merge Requests

Closes #1992 (closed)

Summary of Changes

Omit notifications from banned users - currently, we are only doing the ACL read to check whether the entity is readable (on export), NOT the sender.

Testing Considerations

• Test notifications all show and are grouped and merged properly.
• Test banned state results in no notification being shown.

Regression Scope

Effects when notifications should be shown.

Platform Affected (web, mobile, etc)

Web

Developer Testing Completed

• Build out a testbed for the notifications manager to ensure that if the ACL read fails notifications are omitted.
• Manual testing.

Screenshots

This isn't really screenshotable, either the banned user notifs are present and they are not, and this happens appropriately when testing.

Does this impact

• Localization
• Dark/light mode
• Guest mode