Skip to content

Auto-propagate video height and width to activities on webhook #1965

Ben requested to merge fix/vid-dimensions-propagation-1965 into master

Ticket(s) / Related Merge Requests

#1965 (closed)

Summary of Changes

Make webhook updates to video entity propagate to associated activity entities.

Testing Considerations

Videos are down on sandboxes currently pending the resolution of #2267 (closed)

Activity entity details can be found by finding the activity in a feed and filtering your network requests by api/v2/feeds/subscribed/activities - you can see the width and height in the custom data.

If there is a way to call the webhook (and the sandbox to think you are calling from the cloudflare context), you can run this with the entity_guid from the above endpoint:

{
    "status": {
        "state": "ready"
    },
    "meta": {
        "guid": "1317442400951472130"
    },
    "input": {
        "width": 303,
        "height": 303
    }
}

And check that the activity at the above endpoint updates when you run the endpoint.

Regression Scope

Minor, propagates properties to the activity on cloudflare webhook.

Platform Affected (web, mobile, etc)

Web and mobile - mobile should consider testing on staging? (cc/ @msantang78)

Developer Testing Completed

Manual

Screenshots

N/A

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Ben

Merge request reports