Skip to content

Add in bespoke error for rewards registration from Canada #2182

Ben requested to merge fix/canadian-lookup-err-2182 into master

Ticket(s) / Related Merge Requests

From #2182 - Does not close the card

Summary of Changes

Adding in a bespoke error message when Canadian phone numbers are used to register for rewards - as currently they just see a generic error message.

Testing Considerations

Rate limits will make this very difficult to QA without K8S set up. You will get a few attempts then be blocked unless you clear the cache and wait for it to recreate via

kubectl delete -n caching-new pod/redis-master-0

Need to try registering for rewards.

  • Test valid number(s)
  • Test Invalid number(s)
  • Test Canadian number(s) (DM me for one)

Regression Scope

Effects the error messages returned when trying to verify the phone number only.

Does not affect any front-end UI, including the error message at the bottom of the modal after submitting a phone number ("Invalid phone number"), alignment of buttons, or the American flag showing when you select the Canadian one - these are all things that could be logged separately.

Platform Affected (web, mobile, etc)

Engine / web and mobile.

Developer Testing Completed

Manual

Screenshots

image

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Nicholas Lewis

Merge request reports