Skip to content

Onchain limit #1471

Ben requested to merge fix/onchain-limit-2856 into master

Closes #1471 (closed)

Summary

We do an onchain check but the txid which is used to derive onchain state is null. It does so happen we pass in whether its onchain anyway, so we don't need to derive it from any objects.

Steps to test

We're gonna do this on mainnet - if you need enough ETH I have a few dollars in metamask I can send that will allow testing. You only need a fractional amount of eth because we're going to be setting the gas fee to virtually free so that the TX doesn't get confirmed.

Wallet Connection
  1. If your wallet isn't connected head into wallet and make sure metamask is linked
  2. Try linking with testnet, and back to mainnet.
  3. Try switching to a fresh browser if you have issues.
Steps
  1. Make 2 posts, offchain 1, offchain 2.
  2. Make a third post, onchain 1, try to boost it offchain for 100 views
  3. You should see the error.
  4. Try boost it with onchain Set the gas fee in advanced options to 0.1, it should allow you to make it.
  5. Test you can still make a duplicate boost offchain
  6. Check boosts appeared in console; reject.

Regression Scope

Shouldn't have much potential but the scope would be localized at the boost endpoint - maybe an issue would cause an XHR error.

Edited by Ben

Merge request reports