Skip to content

Group moderation feed ES migration

Ben requested to merge fix/moderation-queue-migration into master

Closes #1381 (closed)

Summary

The issue is that sometimes feeds of popular groups, like H&S, MOSC, Subverse lock up and stop loading - this was seemingly something to do with an entity hydration failure. The other issue is that the moderation queue count for some groups is off - it shows more than are returned when you check them.

Steps

TURN OFF CANARY! UX2020 is missing the 'your post is scheduling' bar, so you will have trouble seeing what is happening.

  1. Make an account - use a password and username combo that you won't forget as we need to log back in.
  2. Make a moderated group
  3. Make 5 numbered posts that bypass moderation. (1,2,3,4,5)
  4. Copy the group URL
  5. Log in as another user, go to the link you copied
  6. Post numbers 5, 6, 7
  7. Log out and back in as the group owner
  8. Check the moderation queue count is correct
  9. Check the queue, try approving, rejecting

Regression Scope

This MR contains low -level changes to the group feeds that have been crafted to minimize the chance of breakage by isolating behavior into if statements, that (mostly) aren't ran if the count parameter is passed in. Nonetheless, feeds should be tested to be working, ideally putting this on a Beatles server or going under heavy staging review.

Edited by Ben

Merge request reports