Banned user message handling minds#4898

Ticket(s) / Related Merge Requests

minds#4898 (closed)

Summary of Changes

Runs messages through the ACL such that the messages of a banned user should not be visible.

Testing Considerations

Note: we need to flesh out a more thorough access control layer for messages in #2740. It is known at the time of submission that:

• Banned users one on one chats will still, even though their messages do not.
• The rooms "last message" in the rooms list will still show messages from a banned user.
• The members list of a room will still show banned users.

This MR addresses banned messages showing.

• Messages do not appear when a user is banned.
• Messages appear when a user is not banned.
• I cannot send a message after leaving a room (keep the room open and leave in another tab).

Any other discrepancies found, please add them to #2740

Deployment Considerations

Standard deployment.

Regression Scope

Chat messages.

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

Manual, unit (phpspec).

Screenshots / Screen Recording

simplescreenrecorder-2024-06-06_19.07.24

simplescreenrecorder-2024-06-07_18.07.59

Does this impact

• Localization
• Dark/light mode
• Guest mode

Definition of Done Checklist

• The Acceptance Criteria has been met
• Code is tested: Testing includes unit/spec, E2E/automated and manual testing
• Merge requests description has been filled out