Skip to content

Include blogs in 1-remind logic minds#4552

Olivia Madrid requested to merge fix/remind-blog-m4552 into master

Ticket(s) / Related Merge Requests

minds#4552 (closed)

Summary of Changes

Blogs can be reminded. Those reminds can be deleted. Previously it was not possible to remind blogs from SEPs or blog pages because certain functions were expecting to receive an Activity type object - now those functions accept Blog types as well (accommodations were made to check for related reminds by entity_guid)

As was already the case, there is still a lot of UX polishing that could be done here (live updating remind metrics, toast messages on undo, for example), but the functionality is there.

Testing Considerations

Reminds, reminding blogs, quotes

Deployment Considerations

Regression Scope

Reminds

Platform Affected (web, mobile, etc)

Both

Developer Testing Completed

  • Blogs can be reminded and unreminded from feed
  • Blogs can be reminded and unreminded from SEPs
  • Blogs can be reminded and unreminded from blog pages
  • Any mixture of the above
  • Blogs can still be quoted, no change
  • Non-blogs can still be reminded and quoted, no change
  • Can't remind a blog twice

Screenshots / Screen Recording

Remind and unremind from feed

__remindBlogAndUndoRemindFromFeed

Remind and unremind from SEP

__remindBlogFromSEPUnremindFromSEP

Remind and unremind from blog

__remindAndUnremindBlogFromBlog

Remind from SEP and unremind from feed

__remindBlogFromSEPUnremindFromFeed

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Olivia Madrid

Merge request reports